Reduce ripple quantity, increase default rain ripple density config o…

…ption, close #223
Ladysnake · Sep 24, 2024 · 1e71d58 · 1e71d58
1 parent 639d762
commit 1e71d58
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/client/java/org/ladysnake/effective/core/EffectiveConfig.java b/src/client/java/org/ladysnake/effective/core/EffectiveConfig.java
@@ -24,7 +24,7 @@ public class EffectiveConfig extends MidnightConfig {
 	@Entry(category = visuals, min = 0, max = 10, isSlider = true)
 	public static float lapisBlockUpdateParticleChance = 1;
 	@Entry(category = visuals, min = 0, max = 10, isSlider = true)
-	public static int rainRippleDensity = 1;
+	public static int rainRippleDensity = 5;
 	@Entry(category = visuals)
 	public static boolean glowingPlankton = true;
 	@Entry(category = visuals)

diff --git a/...t/java/org/ladysnake/effective/core/mixin/water/RippleAndFlowingWaterSplashesSpawner.java b/...t/java/org/ladysnake/effective/core/mixin/water/RippleAndFlowingWaterSplashesSpawner.java
@@ -56,7 +56,7 @@ private static boolean shouldRipple(World world, BlockPos pos) {
 
 		// still water rain ripples
 		if (shouldRipple(world, pos)) {
-			for (int i = 0; i <= random.nextInt(EffectiveConfig.rainRippleDensity); i++) {
+			if (random.nextInt(10) <= EffectiveConfig.rainRippleDensity) {
 				if (world.getBiome(pos).value().getPrecipitation(pos) == Biome.Precipitation.RAIN && world.isSkyVisibleAllowingSea(pos)) {
 					EffectiveUtils.spawnWaterEffect(world, Vec3d.ofCenter(pos).add(random.nextFloat() - random.nextFloat(), .39f, random.nextFloat() - random.nextFloat()), 0f, 0f, 0f, EffectiveUtils.WaterEffectType.RIPPLE);
 				}