Skip to content
This repository has been archived by the owner on Aug 26, 2023. It is now read-only.

[ui] remove package_info_plus dependency #335

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

triallax
Copy link
Member

@triallax triallax commented Jul 3, 2022

Description

Remove package_info_plus dependency.

Benefits:

  • Fewer dependencies (yay!)
  • We now need to update the app version on new releases only in two places: pubspec.yaml and lib/constants.dart. I plan to create a release guide so we don't forget either when creating a new release (see Add a release guide/checklist/whatever #285).

Testing

Run the app and check the following:

  • The app version in the about and libraries pages is correct
  • When you press on the changelog list tile, it opens the correct GitHub release
  • The libraries page has "Clima" as the app name
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • The correct base branch is being used, if not master

@triallax triallax changed the title [ui] remove package_info_plus dependency [ui] remove package_info_plus dependency Jul 3, 2022
Benefits:
- Fewer dependencies (yay!)
- We now need to update the app version on new releases only in two
  places: `pubspec.yaml` and `lib/constants.dart`. I plan to create a
  release guide so we don't forget either when creating a new
  release[1].

[1]: Lacerte#285
@triallax triallax force-pushed the remove-package-info-plus branch from 0c681d9 to 5deaf6d Compare July 3, 2022 13:55
@prestosole prestosole merged commit fdb9a67 into Lacerte:master Jul 5, 2022
@triallax triallax deleted the remove-package-info-plus branch July 5, 2022 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants