-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theory prediction for miscentered haloes #622
base: main
Are you sure you want to change the base?
Conversation
…611) * Add missing use_weights option to notebook to get expected behaviour * Update version to 1.11.1 --------- Co-authored-by: m-aguena <[email protected]>
* distinguish between compute_beta_s_*_from_distribution and compute_beta_s_*_from_weights * make compute_beta more efficient and fix shape_weights=None in compute_beta_s_mean*_from_weights * add _eval_da, _eval_da_z1z2, _get_z_from_a, _get_a_from_z to cosm * reorder funcs in cosmo parent * add fix to skip pylint for astropy.units (fails in astropy 6) * Update version to 1.12.0 --------- Co-authored-by: m-aguena <[email protected]>
@m-aguena, @marina-ricci, @hsinfan1996 - following on the v2.0 release discussion and the idea of having miscentered profiles predictions part of the release, I'm thinking one compromise would be to implement the miscentered profile for a single halo (i..e not integrated over a miscentering distribution). This is in any case what we have currently in theory, i..e we don't deal with prediction for stacked profiles (that will most likely live in FireCrown/new CLcosmo prediction module?). There are 2 routes to do so, both shown in the
I like option 2 better because of speed, but it would also make that part less consistent "in spirit" with the rest of the theory module that relies on the backends... What do you think? |
97b48c7
to
461c3d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good. Thanks for all the hard work! (Just remember to clean the merge comment because it is huge)
Add functionality to compute profile predictions for miscentered haloes, based on tests performed in the exploratory notebook
explore_miscentering_theory.ipynb