HOTFIX Devices/Device.py: report unsupported feature for switchdev corner case #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases a query of switchdev info on a device could return an empty string. When this happens the code expects either legacy or switchdev mode in the output, otherwise a DeviceError is raised. The DeviceError causes termination of the machine's device cleanup process and some devices may be left without deconfiguration. Since this case should not be considered as a critical issue a DeviceFeatureNotSupported is raised instead that is accepted during the deconfiguration. Signed-off-by: Jan Tluka <[email protected]>
olichtne
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases a query of switchdev info on a device could return an empty string. When this happens the code expects either legacy or switchdev mode in the output, otherwise a DeviceError is raised.
The DeviceError causes termination of the machine's device cleanup process and some devices may be left without deconfiguration.
Since this case should not be considered as a critical issue a DeviceFeatureNotSupported is raised instead that is accepted during the deconfiguration.
Description
(Please provide an overall description of what your Merge request is trying to
do.)
Tests
(Please provide a list of tests that prove that the pull
request doesn't break the stable state of the master branch. This should
include test runs with valid results for all of critical workflows.)
Reviews
(Please add a list of reviewers that should check the validity and sanity of
this merge request before it's accepted. Use the
@usernamesyntax. If youdon't know who to mention just link
@all.)Closes: #