Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX Devices/Device.py: report unsupported feature for switchdev corner case #353

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jtluka
Copy link
Collaborator

@jtluka jtluka commented Dec 8, 2023

In some cases a query of switchdev info on a device could return an empty string. When this happens the code expects either legacy or switchdev mode in the output, otherwise a DeviceError is raised.

The DeviceError causes termination of the machine's device cleanup process and some devices may be left without deconfiguration.

Since this case should not be considered as a critical issue a DeviceFeatureNotSupported is raised instead that is accepted during the deconfiguration.

Description

(Please provide an overall description of what your Merge request is trying to
do.)

Tests

(Please provide a list of tests that prove that the pull
request doesn't break the stable state of the master branch. This should
include test runs with valid results for all of critical workflows.)

Reviews

(Please add a list of reviewers that should check the validity and sanity of
this merge request before it's accepted. Use the @username syntax. If you
don't know who to mention just link @all.)

Closes: #

In some cases a query of switchdev info on a device could return an empty
string. When this happens the code expects either legacy or switchdev
mode in the output, otherwise a DeviceError is raised.

The DeviceError causes termination of the machine's device cleanup
process and some devices may be left without deconfiguration.

Since this case should not be considered as a critical issue a
DeviceFeatureNotSupported is raised instead that is accepted during the
deconfiguration.

Signed-off-by: Jan Tluka <[email protected]>
@olichtne olichtne merged commit 9ab0214 into LNST-project:master Dec 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants