Report job timeouts as FAIL #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtluka
reviewed
Nov 22, 2023
Mainly use correct types.
On the Agent, there are always 2 instances of a Job class: * the main process instance - this is the one that the Agent server process is using and has the "parent pipe" to read data from: * the forked process instance - this is the one that actually runs the job process and on finishing the job sends result data over "child pipe" back to the agent process. When the Job.kill() method is called, this is in the context of the Agent process. In case the signal used is SIGKILL, the forked process doesn't have a chance to send the result data back to the Agent. Instead we need to "fake" this from the Agent process. Previously the code called: 1. set_finished 2. send_data This doesn't work correctly because 'set_finished' closes both the parent and the child pipes in the Agent process... so even if we attempt to write into the child pipe, we can't read from it and pass the data back to the Controller. Instead the solution is to ONLY call the "send_data" method to write into the child_pipe. The Agent process can now properly read from the "parent_pipe" in the server loop, and when it does so... it also additionally calls the "set_finished" method which cleans up the opened pipes as well as forwards the Job results back to the Controller. Signed-off-by: Ondrej Lichtner <[email protected]>
Kuba314
force-pushed
the
job-timeout-fail
branch
from
8707c49
to
68e6c73
Compare
`imp` module is removed in python3.12
olichtne
approved these changes
Nov 24, 2023
enhaut
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Job timeouts should be reported as failures.
Tests
J:8577504Reviews
@jtluka
Closes: #233