-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies linux #332
base: master
Are you sure you want to change the base?
Dependencies linux #332
Changes from all commits
6157cf7
930e809
b520758
294d4ac
0731dff
e173c06
b397982
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,8 +10,6 @@ | |
[email protected] (Jan Tluka) | ||
""" | ||
|
||
from pyroute2.netlink import NetlinkError | ||
from pyroute2.netlink.generic.l2tp import L2tp | ||
from lnst.Common.DeviceError import DeviceError, DeviceConfigError | ||
from lnst.Devices.Device import Device | ||
|
||
|
@@ -55,6 +53,11 @@ def test(self): | |
_mandatory_opts = ["tunnel_id", "session_id", "peer_session_id"] | ||
|
||
def __init__(self, ifmanager, *args, **kwargs): | ||
from pyroute2.netlink import NetlinkError | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think we should have a generic |
||
from pyroute2.netlink.generic.l2tp import L2tp | ||
global NetlinkError | ||
global L2tp | ||
|
||
self._name = None | ||
for i in self._mandatory_opts: | ||
if i not in kwargs: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,8 +19,8 @@ include = ["schema-am.rng", "install/*", "lnst-ctl.conf"] | |
[tool.poetry.dependencies] | ||
python = "^3.9" | ||
lxml = "*" | ||
ethtool = "*" | ||
pyroute2 = "*" | ||
ethtool = {version = "*", platform = 'linux'} | ||
pyroute2 = {version = "*", platform = 'linux'} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think if possible i'd also like this to be split in a way that these only install on the Agent installations... and a pure controller installation doesn't need these. simply for situations when i want to install a pure controller on linux, this will still want to install these dependencies. |
||
|
||
libvirt-python = {version = "*", optional = true } | ||
podman = {version = "*", optional = true } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i grepped this in the repo and we don't actually use this function anywhere... i think we should just remove it completely...
originally i wanted to know if this was in any way used on the controller, because this seems like an agent only function anyway.