Skip to content

Commit

Permalink
Recipes/ENRT/CommonHWSubConfigMixin: replace coalescing mixin
Browse files Browse the repository at this point in the history
The CoalescingHWConfigMixin is only capable of disabling adaptive TX/RX
setting. Typically the user disables adaptive coalescing and configures
specific values of rx/tx-usecs and others. Not setting these would
result in non-deterministic behaviour of the setup.

The MultiCoalescingHWConfigMixin is capable of setting any coalescing
options, so using it instead of CoalescingHWConfigMixin makes sense.

Signed-off-by: Jan Tluka <[email protected]>
  • Loading branch information
jtluka committed Mar 21, 2024
1 parent 257e530 commit c660dfe
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lnst/Recipes/ENRT/ConfigMixins/CommonHWSubConfigMixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
from lnst.Recipes.ENRT.ConfigMixins.DevInterruptHWConfigMixin import (
DevInterruptHWConfigMixin,
)
from lnst.Recipes.ENRT.ConfigMixins.CoalescingHWConfigMixin import (
CoalescingHWConfigMixin,
from lnst.Recipes.ENRT.ConfigMixins.MultiCoalescingHWConfigMixin import (
MultiCoalescingHWConfigMixin,
)
from lnst.Recipes.ENRT.ConfigMixins.MTUHWConfigMixin import MTUHWConfigMixin
from lnst.Recipes.ENRT.ConfigMixins.PauseFramesHWConfigMixin import (
Expand All @@ -17,7 +17,7 @@ class CommonHWSubConfigMixin(
PauseFramesHWConfigMixin,
ParallelStreamQDiscHWConfigMixin,
DevInterruptHWConfigMixin,
CoalescingHWConfigMixin,
MultiCoalescingHWConfigMixin,
MTUHWConfigMixin,
):
"""
Expand Down

0 comments on commit c660dfe

Please sign in to comment.