Multi-material solid mechanics #1249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btalamini
changed the title
white238
reviewed
Oct 23, 2024
| { | ||
| int Q = order + 1; | ||
|
|
||
| std::array<uint32_t, mfem::Geometry::NUM_GEOMETRIES> elems = geometry_counts(domain); |
There was a problem hiding this comment.
There is only two lines different in this vs the mesh_tag newQuadratureDataBuffer function. Can you reduce the duplication between them?
white238
reviewed
Oct 23, 2024
|
|
||
| auto& pmesh = serac::StateManager::setMesh(std::move(mesh), mesh_tag); | ||
|
|
||
| // _solver_params_start |
There was a problem hiding this comment.
These tags are used in the sphinx documentation and are not needed here. Looking at the code these tags have bled into other files and should only be in serac/physics/tests/solid.cpp.
white238
reviewed
Oct 23, 2024
|
|
||
| #include "serac/physics/solid_mechanics.hpp" | ||
|
|
||
| #include "axom/slic/core/SimpleLogger.hpp" |
There was a problem hiding this comment.
Suggested change
| #include "axom/slic/core/SimpleLogger.hpp" |
This isn't needed due to using the serac::initiliaze call which uses the Serac SLIC logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable solid mechanics to work with materials defined on different domains. Includes materials with internal state variables.
For now, I added this without breaking changes. This means I overloaded the
setMaterialseveral times and left in place the old ones that do not take a domain. Eventually, I'd prefer the domain to be required. We can map this out later.