Use enable_language(HIP) #702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
white238
reviewed
Oct 10, 2024
white238
reviewed
Oct 10, 2024
white238
reviewed
Oct 10, 2024
adayton1
reviewed
Oct 14, 2024
white238
reviewed
Jan 23, 2025
white238
reviewed
Jan 23, 2025
white238
reviewed
Jan 23, 2025
cmake/thirdparty/BLTSetupHIP.cmake
Outdated
| EXPORTABLE ${BLT_EXPORT_THIRDPARTY} | ||
| GLOBAL ${_blt_hip_is_global}) | ||
|
|
||
| # Hard-copy inheritable properties instead of depending on hip::device so that we can export | ||
| # all required information in our target blt_hip | ||
| blt_inherit_target_info(TO blt_hip FROM hip::device OBJECT FALSE) | ||
| #blt_inherit_target_info(TO blt_hip FROM hip::device OBJECT FALSE) |
There was a problem hiding this comment.
Remove dead code and fix comments please.
white238
reviewed
Jan 23, 2025
host-configs/llnl/toss_4_x86_64_ib_cray/[email protected][email protected]_hip.cmake
Outdated
Show resolved
Hide resolved
white238
approved these changes
Jan 23, 2025
Co-authored-by: Chris White <[email protected]>
adayton1
reviewed
Feb 4, 2025
| @@ -41,32 +47,7 @@ message(STATUS "ROCM path: ${ROCM_PATH}") | |||
| message(STATUS "HIP version: ${hip_VERSION}") | |||
|
|
|||
| # AMDGPU_TARGETS should be defined in the hip-config.cmake that gets "included" via find_package(hip) | |||
| # This file is also what hardcodes the --offload-arch flags we're removing here | |||
| if(DEFINED AMDGPU_TARGETS) | |||
There was a problem hiding this comment.
It seems like there's no longer a point for having AMDGPU_TARGETS.
There was a problem hiding this comment.
Or is it used internally by hip's CMake setup?
adayton1
reviewed
Feb 4, 2025
| EXPORTABLE ${BLT_EXPORT_THIRDPARTY} | ||
| DEPENDS_ON blt_hip_runtime |
There was a problem hiding this comment.
If this depends on blt_hip_runtime, shouldn't the target be created after the blt_hip_runtime target is created?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #596 , but doesn't support hipcc