-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Caliperize hpcg #295
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* show example of not using allocation modifier * restore test config * I was hoping I could expand variables into lists; but I don't think that will work * variable naming consistency * refactor as multi-line strings vs string lists * add test config; demonstrates an odd behavior for expansion of multi-line strings * expand test config * needed for emulating #258 * missing space * style fix * style fix 2 * forgot to re-add argument with new format * relocate execute_experiment template
#300) Fix variables.yaml to reflect the correct number of gpus per node on tioga Co-authored-by: Riyaz Haque <[email protected]>
* Updating Spack to latest tag spack/spack#44533 seems to be resolved.
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6546280...0b2256b) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* underscore * underscores
github-actions
bot
added
ci
CI, unit tests, GitHub actions
system
New or modified system config
application
labels
Jul 10, 2024
pearce8
added
WIP
A work-in-progress not yet ready to commit
and removed
ci
CI, unit tests, GitHub actions
labels
Sep 27, 2024
Subsumed by #525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
experiment
New or modified experiment
system
New or modified system config
WIP
A work-in-progress not yet ready to commit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@rfhaque this PR is very out of date. Please evaluate what needs to be done to get this work merged.
This branch adds required caliper annotations to hpcg config in anticipation of the benchmark's caliperization.
Should not be merged till the actual benchmark source is caliperized.
Dependencies: FIXME:Add a list of any dependencies.
Fixes issue(s): FIXME:Add list of relevant issues.
Type of Change
Checklist:
If adding/modifying a system:
system.py
file.github/workflows
If adding/modifying a benchpark:
application.py
and (maybe)package.py
under a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.py
under existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflows
and.gitlab/ci
unit tests (if needed)