Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Caliperize hpcg #295

Closed
wants to merge 8 commits into from
Closed

[Draft] Caliperize hpcg #295

wants to merge 8 commits into from

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Jun 22, 2024

Description

@rfhaque this PR is very out of date. Please evaluate what needs to be done to get this work merged.

This branch adds required caliper annotations to hpcg config in anticipation of the benchmark's caliperization.
Should not be merged till the actual benchmark source is caliperized.

Dependencies: FIXME:Add a list of any dependencies.

Fixes issue(s): FIXME:Add list of relevant issues.

Type of Change

  • { } Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@rfhaque rfhaque requested a review from pearce8 June 22, 2024 03:19
@github-actions github-actions bot added the experiment New or modified experiment label Jun 22, 2024
@rfhaque rfhaque changed the title Add caliper annotation to hpcg config Caliperize hpcg Jun 22, 2024
@rfhaque rfhaque changed the title Caliperize hpcg [Draft] Caliperize hpcg Jun 22, 2024
scheibelp and others added 7 commits July 10, 2024 11:11
* show example of not using allocation modifier

* restore test config

* I was hoping I could expand variables into lists; but I don't think that will work

* variable naming consistency

* refactor as multi-line strings vs string lists

* add test config; demonstrates an odd behavior for expansion of multi-line strings

* expand test config

* needed for emulating #258

* missing space

* style fix

* style fix 2

* forgot to re-add argument with new format

* relocate execute_experiment template
#300)

Fix variables.yaml to reflect the correct number of gpus per node on tioga

Co-authored-by: Riyaz Haque <[email protected]>
* Updating Spack to latest tag

spack/spack#44533 seems to be resolved.
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@6546280...0b2256b)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* underscore

* underscores
@github-actions github-actions bot added ci CI, unit tests, GitHub actions system New or modified system config application labels Jul 10, 2024
@pearce8 pearce8 added WIP A work-in-progress not yet ready to commit and removed ci CI, unit tests, GitHub actions labels Sep 27, 2024
@rfhaque
Copy link
Collaborator Author

rfhaque commented Jan 23, 2025

Subsumed by #525

@rfhaque rfhaque closed this Jan 23, 2025
@slabasan slabasan deleted the spackage/hpcg branch January 25, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment New or modified experiment system New or modified system config WIP A work-in-progress not yet ready to commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants