-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update and sandardize implementation of packages, in sync with spack update #480
base: develop
Are you sure you want to change the base?
Conversation
@adrienbernede I don't understand why SYCL CI is failing. I can build and run the tests manually on corona using the The build script mentioned here may be helpful for you to get the CI SYCL build correct. |
Also, OpenMP can be enabled for the SYCL checks. |
@rhornung67
I'll try with your fix. |
This reverts commit 353e552.
@adrienbernede the intel 2023 failure can be fixed by adding the flag |
@rhornung67 Is the floating point model something that can be changed for RAJA only, or should it propagate to the project using RAJA as a dependency ? In the former case, we could apply the flag via CMake or via Spack. In the latter case... well I hope it's not the latter... |
Actually, all projects using the intel compiler that I know of set that flag. However, we should apply it via CMake and not Spack. That just means use |
@adrienbernede it looks like the SYCL job on corona is not running on a node with GPUs. It fails, but we are allowing failure, which we don't want. Will you please take a look? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not merge this until we fix the corona SYCL CI job. I haven't been able to reproduce the failure.
…optim/spack-update
@adrienbernede I pushed a change to the raja-perf spack package that may fix the SYCL CI issue. If this works, we will need to merge a sequence of PRs, in order: first pull radiuss-spack-configs branch with Spack package change, second pull updated radiuss-spack-configs main into RAJA develop, third pull new RAJA develop into this PR branch. Then, we should be able to merge this (fingers crossed). |
Summary
This PR :
👀 Deserves some consideration:
.uberenv-config.json
.