Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit casts to/from ManagedArray #285

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Remove implicit casts to/from ManagedArray #285

merged 4 commits into from
Oct 29, 2024

Conversation

adayton1
Copy link
Member

@adayton1 adayton1 commented Oct 29, 2024 •
edited
Loading

  • Remove optional support for implicitly casting between raw pointers and ManagedArrays
  • Remove CHAI_ENABLE_IMPLICIT_CONVERSIONS configuration option
  • Use makeManagedArray and ManagedArray::data to perform explicit conversions
  • Remove operator== and operator!= overloads for raw pointers (can easily accomplish this using ManagedArray::data)

@adayton1 adayton1 changed the title Remove implicit casts Remove ManagedArray implicit casts Oct 29, 2024
robinson96
robinson96 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@robinson96 robinson96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1 adayton1 merged commit 7ba2ba8 into develop Oct 29, 2024
14 checks passed
@adayton1 adayton1 deleted the feature/dayton8/rm_implicit_casts branch October 29, 2024 20:38
@adayton1 adayton1 changed the title Remove ManagedArray implicit casts Remove implicit casts to/from ManagedArray Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaller dtaller dtaller approved these changes

@liu15 liu15 liu15 approved these changes

@robinson96 robinson96 robinson96 approved these changes

@davidbeckingsale davidbeckingsale Awaiting requested review from davidbeckingsale

@rchen20 rchen20 Awaiting requested review from rchen20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adayton1 @robinson96 @liu15 @dtaller