-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabale reproducer #281
Tabale reproducer #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -71,8 +71,6 @@ cmake_dependent_option(CHAI_ENABLE_DOCS "Build CHAI docs" On | |||
"ENABLE_DOCS" Off) | |||
cmake_dependent_option( CHAI_ENABLE_GMOCK "Build CHAI with gmock" On | |||
"ENABLE_GMOCK" Off ) | |||
cmake_dependent_option(CHAI_ENABLE_REPRODUCERS "Build CHAI reproducers" On |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ENABLE_REPRODUCERS is not a variable defined anywhere (unlike ENABLE_TESTS for example, which is a BLT variable). Even if it was, I don't think it makes sense for it to be a dependent variable. It is already an option in cmake/SetupChaiOptions.cmake.
@liu15 . I would put somthing like this (explanation of the reproducer and what systems it fails on and how) as a comment at the top of the reproducer or in a README file somewhere. Those details would be useful to figuring out what it wrong, so it would be nice to have it documented there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides adding a readme or big comment explaining the reproducer (as I suggested in my last comment), this looks good.
To reproduce crash on rzadams:
mkdir build_rocm
cd build_rocm
cmake -DCHAI_ENABLE_REPRODUCERS=1 -C ../configs/lc/toss_4_x86_64_ib_cray/amdclang.cmake ..
flux alloc -N 1 -n 1 -g1 make -j 40
flux alloc -N 1 -n 1 -g1 ./bin/managed_ptr_multiple_inheritance_reproducer.exe
The rzansel case does not crash and has consistent pointer addresses in YofXfromRTTable1D. This can be reproduced with
mkdir build_cuda
cd build_cuda
cmake -DCHAI_ENABLE_REPRODUCERS=1 -C ../configs/lc/blueos_3_ppc64le_ib_p9/nvcc_clang.cmake ..
lalloc 1 make -j 40
lalloc 1 ./bin/managed_ptr_multiple_inheritance_reproducer.exe