Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error in raja-chai integration test #276

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix syntax error in raja-chai integration test #276

merged 2 commits into from
Sep 10, 2024

Conversation

liu15
Copy link
Collaborator

@liu15 liu15 commented Sep 9, 2024 •
edited by adayton1
Loading

  • Fix syntax error in tests when implicit conversions are disabled
  • Avoid building non-essential stuff in umpire and raja (to speed up CI and also avoid running out of disk space in the CI)

@liu15 liu15 requested a review from adayton1 September 9, 2024 22:56
adayton1
adayton1 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@adayton1 adayton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1 adayton1 merged commit 09fe8af into develop Sep 10, 2024
9 checks passed
@adayton1 adayton1 deleted the fixTest branch September 10, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaller dtaller dtaller approved these changes

@adayton1 adayton1 adayton1 approved these changes

@robinson96 robinson96 Awaiting requested review from robinson96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liu15 @adayton1 @dtaller