-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RADIUSS packages w.r.t. spack@develop-2024-07-07 #264
Conversation
@adayton1 it looks like CHAI@develop does not play well with [email protected]. |
@adayton1 the CHAI tests need to be updated by subbing 'seq_exec' for 'loop_exec'. |
This is fixed now. |
I just released [email protected] which works with [email protected]. |
@adayton1 There is another error in the integration tests. This time it involves Umpire and fmt, so I’m gonna invoke @davidbeckingsale ;) |
I think I recently encountered this and worked around it by using the fmt compiled library (-DUMPIRE_FMT_TARGET=fmt::fmt) instead of the header only library (-DUMPIRE_FMT_TARGET=fmt::fmt-header-only). Sadly, nvcc really doesn't seem to get along well with fmt. |
We will need to add a variant to Umpire to enable this - let me know how we should co-ordinate it. @adrienbernede would you like me to send you a patch for radiuss-spack-configs, or just submit a PR? |
@davidbeckingsale you can either send me the patch or add it to LLNL/radiuss-spack-configs#105 |
Done. |
@adayton1 This is ready. |
src/tpl/raja
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test changes from LLNL/radiuss-spack-configs#105