Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RADIUSS packages w.r.t. spack@develop-2024-07-07 #264

Merged
merged 16 commits into from
Jul 16, 2024

Conversation

adrienbernede
Copy link
Member

Test changes from LLNL/radiuss-spack-configs#105

@adrienbernede
Copy link
Member Author

@adayton1 it looks like CHAI@develop does not play well with [email protected].

@adrienbernede adrienbernede changed the title Update RADIUSS packages w.r.t. spack@develop-2024-06-16 [WIP] Update RADIUSS packages w.r.t. spack@develop-2024-06-16 Jun 25, 2024
@rhornung67
Copy link
Member

@adayton1 the CHAI tests need to be updated by subbing 'seq_exec' for 'loop_exec'.

@adayton1
Copy link
Member

@adayton1 the CHAI tests need to be updated by subbing 'seq_exec' for 'loop_exec'.

This is fixed now.

@adayton1
Copy link
Member

@adayton1 it looks like CHAI@develop does not play well with [email protected].

I just released [email protected] which works with [email protected].

@adrienbernede
Copy link
Member Author

@adayton1 There is another error in the integration tests. This time it involves Umpire and fmt, so I’m gonna invoke @davidbeckingsale ;)

@adayton1
Copy link
Member

@adayton1 There is another error in the integration tests. This time it involves Umpire and fmt, so I’m gonna invoke @davidbeckingsale ;)

I think I recently encountered this and worked around it by using the fmt compiled library (-DUMPIRE_FMT_TARGET=fmt::fmt) instead of the header only library (-DUMPIRE_FMT_TARGET=fmt::fmt-header-only). Sadly, nvcc really doesn't seem to get along well with fmt.

@davidbeckingsale
Copy link
Member

We will need to add a variant to Umpire to enable this - let me know how we should co-ordinate it. @adrienbernede would you like me to send you a patch for radiuss-spack-configs, or just submit a PR?

@adrienbernede
Copy link
Member Author

@davidbeckingsale you can either send me the patch or add it to LLNL/radiuss-spack-configs#105

@davidbeckingsale
Copy link
Member

@davidbeckingsale you can either send me the patch or add it to LLNL/radiuss-spack-configs#105

Done.

@adrienbernede adrienbernede changed the title [WIP] Update RADIUSS packages w.r.t. spack@develop-2024-06-16 [WIP] Update RADIUSS packages w.r.t. spack@develop-2024-07-07 Jul 11, 2024
@adrienbernede adrienbernede changed the title [WIP] Update RADIUSS packages w.r.t. spack@develop-2024-07-07 Update RADIUSS packages w.r.t. spack@develop-2024-07-07 Jul 16, 2024
@adrienbernede
Copy link
Member Author

@adayton1 This is ready.

src/tpl/raja Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change still necessary?

Copy link
Member

@adayton1 adayton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1 adayton1 requested review from liu15 and dtaller July 16, 2024 15:12
@adayton1 adayton1 merged commit 390d640 into develop Jul 16, 2024
14 checks passed
@adrienbernede adrienbernede deleted the woptim/add-latest-releases branch July 17, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants