Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve implementation #1

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Improve implementation #1

merged 2 commits into from
Feb 2, 2024

Conversation

mcmikius
Copy link
Contributor

@mcmikius mcmikius commented Feb 2, 2024

Improve implementation after review

  • remove unused protocol
  • extend tests
  • fix potential errors

Copy link

codecov bot commented Feb 2, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@mcmikius mcmikius merged commit 700f0c2 into main Feb 2, 2024
6 checks passed
@mcmikius mcmikius deleted the improve-implementation branch February 2, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants