Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Consul Health checks #16

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Conversation

mcmikius
Copy link
Contributor

update docs
add tests

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 95.06173% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 79.87%. Comparing base (6bbb770) to head (3902c55).
Report is 4 commits behind head on main.

Files Patch % Lines
...ts/HealthChecksTests/ConsulHealthChecksTests.swift 96.09% 5 Missing ⚠️
Tests/HealthChecksTests/Mocks/MockClient.swift 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
+ Coverage   64.95%   79.87%   +14.92%     
===========================================
  Files          17       19        +2     
  Lines         505      631      +126     
===========================================
+ Hits          328      504      +176     
+ Misses        177      127       -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gulivero1773 gulivero1773 merged commit b294423 into main Feb 23, 2024
7 checks passed
@gulivero1773 gulivero1773 deleted the refactor-app-health-checks branch February 23, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants