-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lazer structure #15
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of breaking changes here, I think it would be best to have the user be able to specify the x-api-version
header specifically in the endpoints in which they can be applied and then map out the return types as needed.
so, an enum you would pass in the const client = new Client(accessToken, ApiVersion.Lazer); enum name would be subject to change. |
c9976db
to
acac09e
Compare
dude, I just accidently deleted the branch |
I named the old types to have |
I've adressed the breaking changes. It now automatically returns the old structure unless you pass in |
This pull request updates the library to the api version after lazer's pp release.