Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lazer structure #15

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yorunoken
Copy link
Contributor

This pull request updates the library to the api version after lazer's pp release.

Copy link
Owner

@L-Mario564 L-Mario564 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of breaking changes here, I think it would be best to have the user be able to specify the x-api-version header specifically in the endpoints in which they can be applied and then map out the return types as needed.

@yorunoken
Copy link
Contributor Author

I see a lot of breaking changes here, I think it would be best to have the user be able to specify the x-api-version header specifically in the endpoints in which they can be applied and then map out the return types as needed.

so, an enum you would pass in the Client class while initializing the client?

const client = new Client(accessToken, ApiVersion.Lazer);

enum name would be subject to change.

@yorunoken yorunoken closed this Apr 9, 2024
@yorunoken yorunoken force-pushed the new-lazer-structure branch from c9976db to acac09e Compare April 9, 2024 09:17
@yorunoken
Copy link
Contributor Author

dude, I just accidently deleted the branch

@yorunoken yorunoken reopened this Apr 9, 2024
@yorunoken
Copy link
Contributor Author

I named the old types to have Legacy at the start, let me know if I should put anything else.

@yorunoken
Copy link
Contributor Author

@L-Mario564

I see a lot of breaking changes here, I think it would be best to have the user be able to specify the x-api-version header specifically in the endpoints in which they can be applied and then map out the return types as needed.

I've adressed the breaking changes. It now automatically returns the old structure unless you pass in true after required parameters.

@yorunoken yorunoken requested a review from L-Mario564 April 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants