chore: ImageUpload api 구현 #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlarbals824
reviewed
Feb 28, 2024
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class AwsS3Service { |
There was a problem hiding this comment.
우선 패키지 먼저 정리하자
일단 내가 생각하는 패키지 구조는
- Application
- controller
- application service
- Domain
- domain
- repository
- domain service
- infra
- domain
- domain entity
- repository impl(jpa)
- mapper
- config
- image
- AwsS3ImageUploader
- domain
- global
- 어디서든 사용되는 클래스(ex. ApiResponse, BusinessException, 이미지 업로드 인터페이스 등등)
이렇게 생각중이야
There was a problem hiding this comment.
그래서 일단 이미지 업로드 패키지를 common에다가 둬서
- common
- image
- ImageUploader (interface)
이렇게 인터페이스만 정의하고
- ImageUploader (interface)
- image
There was a problem hiding this comment.
public interface ImageUploader{
List<String> uploadImage(List<MultipartFile> multipartFile);
public void deleteImage(String fileName);There was a problem hiding this comment.
그 구현체들은 infra 패키지에 구현을 해주면 좋을 것 같아. 어떻게 생각해?
There was a problem hiding this comment.
이게 훨씬 깔끔하겠다. 그러면 다시 패키지 정리해서 올릴게!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 이용한 이미지 업로드 기능 api