You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@riven-blade Hi, I've just reviewed the code you submitted, and I think that it looks good to me overall. However, there are still two points I'd like to confirm:
For the kusion release rollback command, should it only allow users to roll back to a previously successfully applied release? Since rolling back to a failed revision doesn't seem meaningful, should we add some validation for this in the command?
Why can't we directly reuse the existing Apply and State related methods? Instead, we have to implement them again, especially creating a new State struct in the release package. Could you please clarify the reasoning behind this?
Hi, I have made major adjustments to the abstraction of the previous apply logic, and the different operations between apply and rollback are completed in the prepare stage. At the same time, the place where fixme was identified in the previous apply logic has been fixed. Now there is no problem with the code logic when I test it, but I think there are still areas where the code can be optimized, and the priority is not that high. I don’t want a PR to be so heavy
kind/featureCategorizes issue or PR as related to a new feature
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
feat: rollback release
Which issue(s) this PR fixes:
Fixes #1028
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: