Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AllBundles] Fix fixture deprecations #3459

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Nov 8, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets comma separated list of tickets fixed by the PR

Method "Doctrine\Common\DataFixtures\FixtureInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "Kunstmaan\GeneratorBundle\DataFixtures\ORM\GroupFixtures" now to avoid errors or add an explicit @return annotation to suppress this message.

Copy link
Member

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically adding those return types are a BC break, but I don't expect anyone extending the fixture classes so let's merge as is! Thanks @dannyvw!

@acrobat acrobat added this to the 7.2.0 milestone Nov 8, 2024
@acrobat acrobat changed the title [All] Fix fixture deprecations [AllBundles] Fix fixture deprecations Nov 8, 2024
@acrobat acrobat merged commit 3752364 into Kunstmaan:7.x Nov 8, 2024
9 checks passed
@dannyvw dannyvw deleted the fixture branch November 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants