[MultidomainBundle] Improve domain based locale router performance #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
requested changes
Nov 1, 2024
There was a problem hiding this comment.
As you mentioned already, we need to keep BC and can't remove those properties and methods (or change visibility)
I like the performance improvements here, so indeed with some kind of option/toggle would be ideal to make improvements and keep BC. Do you have any numbers on the improvement itself? Like blackfire profile of some timings of real apps?
dannyvw
force-pushed
the
domain-router
branch
3 times, most recently
from
b010a60 to
c54dbff
Compare
dannyvw
force-pushed
the
domain-router
branch
from
c54dbff to
ee41e29
Compare
|
@acrobat I pushed some changed. I cannot generate the same blackfire profile as before because we have changed a lot. But the main thing is that is reduced calls to getHost and isMultiLanuage methods. |
acrobat
requested changes
Nov 9, 2024
src/Kunstmaan/MultiDomainBundle/Router/DomainBasedLocaleRouter.php
Outdated
Show resolved
Hide resolved
acrobat
approved these changes
Nov 10, 2024
|
Thanks @dannyvw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/7.x/src/Kunstmaan/MultiDomainBundle/Router/DomainBasedLocaleRouter.php#L175 decrease performance when you have many links. The "isMultiLanguage" check is also done inside "getSlugRouteParameters" so it is not necessary to perform that inside the "getRouteCollection" for every link. Runtime checks inside "getRouteCollection" are slow (https://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Routing/RouterInterface.php#L29)
We have about 20/25% profit on a page with only a menu and footer.
The only BC break is as the removed methods are overridden. We can solve it maybe with an config setting to switch to the improved router? Is this needed to implement?