Refactor Url chooser without XHR call #3432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-insiders
commented
Aug 29, 2024
mart-insiders
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | comma separated list of tickets fixed by the PR |
mart-insiders
force-pushed
the
url-chooser
branch
2 times, most recently
from
c1bba76 to
1e616c4
Compare
mart-insiders
force-pushed
the
url-chooser
branch
from
1e616c4 to
d6e2094
Compare
mart-insiders
force-pushed
the
url-chooser
branch
from
d6e2094 to
5980707
Compare
acrobat
requested changes
Jan 26, 2025
| $loader->load('services.yml'); | ||
| $loader->load('commands.yml'); | ||
|
|
There was a problem hiding this comment.
Can you add check to deprecate not settings this option?
if (!$enableImprovedUrlchooser) {
trigger_deprecation('kunstmaan/node-bundle', '7.2', 'Not setting the "kunstmaan_node.enable_improved_urlchooser" config to true is deprecated, it will always be true in 8.0.');
}
src/Kunstmaan/NodeBundle/Form/EventListener/URLChooserFormSubscriber.php
Outdated
Show resolved
Hide resolved
src/Kunstmaan/NodeBundle/Form/EventListener/URLChooserLinkTypeSubscriber.php
Outdated
Show resolved
Hide resolved
| @@ -56,6 +56,8 @@ services: | |||
|
|
|||
| kunstmaan_node.form.type.urlchooser: | |||
| class: Kunstmaan\NodeBundle\Form\Type\URLChooserType | |||
| arguments: | |||
| $improvedUrlChooser: '%kunstmaan_node.enable_improved_urlchooser%' | |||
There was a problem hiding this comment.
Please don't use named parameters here as function parameter names are not covered by the BC policy
There was a problem hiding this comment.
changed to unnamed parameter
| if (field.name.indexOf($urlChooserName) !== -1 && field.name.indexOf('link_url') === -1) { | ||
| values[field.name] = field.value; | ||
| } | ||
| // deprecated, use adaptUrl(e.target) when enable_improved_urlchooser becomes standard |
There was a problem hiding this comment.
Can you explain what is exactly deprecated? So I understand what to remove in 8.0
There was a problem hiding this comment.
The onclick event should trigger the function adaptUrl for the improved url chooser.
Everything below that is deprecated and only used for the current url chooser.
So, everything from r.222 var $form = $(this).closest('form'), untill r.264 }); is deprecated
…Subscriber.php Co-authored-by: Jeroen Thora <[email protected]>
…criber.php Co-authored-by: Jeroen Thora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.