Callback is now called when the message view is dismissed. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment documentation defines the callback like that that: "The block that should be executed, when the user dismissed the message by tapping on it or swiping it to the top".
Unfortunately right now callback is called only after the message view gets touched.
For my own use I prefer that the callback block gets called whenever the message view is dismissed, whatever is the way it has been dismissed.
Here is my quick proposition of a way to achieve this, not 100% sure if I have done it the best way though (for this purpose it might be a better idea to call the callback directly inside the view before it gets removed from parents...).
This pull request is related to question #139