-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom view for TSMessage (model and view) #134
base: master
Are you sure you want to change the base?
Conversation
Wow, this Pull Request is huge! Thanks a lot for your contribution. |
@KrauseFx please check whether or not it has any implications when we would later try to integrate this into the develop branch |
So what's the real deal here? Are we going to implement this in the 0.X Versions and rebuild this from the scratch in the 1.X develop branch? |
@mRs- I think this should be in the 1.0 release. On the first glance, this PR looks really great and offers a nice way for developers to extend the functionality of TSMessages without touching the core. How about merging this PR into the develop branch and experiment with it a little? |
…is calculating for single line)
Added fix for height calculation. |
@KrauseFx I am apologize in advance if something is not developed carefully, it took me only 1 night for very urgent project. I haven't enough time now to clean everything, but if you want me to help in something don't hesitate. |
Any chance of seeing this (or something like it) implemented? |
Now we can subclass and create own controls under TSMessageView.
I have also separate view and model (item).
Please check example TSMessageCustomItem and TSMessageCustomView.