if param is integer, read it as double, it's not a mistake #12751
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbucher
reviewed
Oct 14, 2024
| @@ -472,7 +472,7 @@ def _assign_nodally_properties(self): | |||
| for key, value in mat["Variables"].items(): | |||
| var = KratosMultiphysics.KratosGlobals.GetVariable(key) | |||
| if (self._check_variable_to_set(var)): | |||
| if value.IsDouble(): | |||
| if value.IsDouble() or value.IsInt(): | |||
There was a problem hiding this comment.
Suggested change
| if value.IsDouble() or value.IsInt(): | |
| if value.IsNumber(): |
perhaps that makes more sense here
There was a problem hiding this comment.
I'd follow @philbucher's suggestion in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this input in ConvectionDiffusionMaterials.json
{ "properties" : [{ "model_part_name" : "ThermalModelPart.Heating", "properties_id" : 2, "Material" : { "Variables" : { "DENSITY" : 0.0, "CONDUCTIVITY" : 10, "SPECIFIC_HEAT" : 0.0 }, "Tables" : null } }] }fails, because the read function says that conductivity value is not properly set.
This allows the user to set 10 instead of 10.0
@rubenzorrilla (lo pongo como draft porque no se si es mejor esta solución, o hacer un mensaje de error más explicativo sobre cual de los parámetros falla, y que el usuario lo corrija)