Fixing erase mode #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add API (getBaseColor, setBaseColor)
Change package.
If the argument is invalid, default value is applied.
Change to use PorterDuffXfermode.
Add section for license.
Korilakkuma
force-pushed
the
master
branch
3 times, most recently
from
7e46eac to
eddc76b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Korilakkuma I have fixed the problem with the erase mode by changing the way of how createPaint method handle with erase mode. As you will see on the code of the createPaint method, I have added a new fixed configuration where I set Paint.setColor(this.paintStrokeColor). Inside the if condition, instead of call Paint.setXfermode() and Paint.setARGB(), I'm calling Paint.setColor(canvasBackgroundColor). I also moved out all the code of the else condition so, in this way, if the user doesn't pick the erase mode ,the createPaint will return a Paint object with the same color of printStrokeColor.