Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-3515] Notification service #3687

Open
wants to merge 90 commits into
base: subwallet-dev
Choose a base branch
from
Open

[Issue-3515] Notification service #3687

wants to merge 90 commits into from

Conversation

bluezdot
Copy link

No description provided.

dungnguyen-art and others added 13 commits September 4, 2024 19:32
@bluezdot bluezdot added this to the Milestone 8 milestone Sep 26, 2024
@bluezdot bluezdot self-assigned this Sep 26, 2024
@bluezdot bluezdot force-pushed the koni/dev/issue-3515 branch 3 times, most recently from 9ace637 to e1961b1 Compare September 27, 2024 02:49
@bluezdot bluezdot linked an issue Sep 27, 2024 that may be closed by this pull request
Implement notification logic #3515
Open
@bluezdot bluezdot force-pushed the koni/dev/issue-3515 branch 4 times, most recently from 8be3399 to 706aa0f Compare September 28, 2024 04:27
@saltict saltict temporarily deployed to pull request October 15, 2024 05:10 Inactive
@saltict saltict temporarily deployed to pull request October 15, 2024 05:43 Inactive
bluezdot and others added 5 commits October 15, 2024 14:13
@bluezdot
Merge branch 'refs/heads/koni/dev/issue-3515' into koni/dev/issue-342…
d863aed 
…3-listen-claim-notification

# Conflicts:
#	packages/extension-base/src/background/KoniTypes.ts
#	packages/extension-base/src/services/inapp-notification-service/consts.ts
@bluezdot
[Issue-3515] feat: update content and optimize validation
2b3c6dd
@S2kael
[Issue-3423] Add information and init UI
b524f51
@S2kael
Merge pull request #3781 from Koniverse/koni/dev/issue-3423-listen-cl…
d013ec4 
…aim-notification

[Issue-3423] Integrate Avail Bridge
@S2kael
[Issue-3423] Fix lint
94af8de
@saltict saltict temporarily deployed to pull request October 16, 2024 07:51 Inactive
@saltict saltict temporarily deployed to pull request October 17, 2024 02:15 Inactive
@saltict saltict temporarily deployed to pull request October 18, 2024 07:39 Inactive
@saltict saltict temporarily deployed to pull request October 18, 2024 08:26 Inactive
@saltict saltict temporarily deployed to pull request October 18, 2024 08:50 Inactive
@S2kael S2kael linked an issue Oct 18, 2024 that may be closed by this pull request
Integrate Avail Bridge #3423
Open
@saltict saltict temporarily deployed to pull request October 18, 2024 09:45 Inactive
@S2kael S2kael linked an issue Oct 18, 2024 that may be closed by this pull request
Extension - Support Notification UI in app #3507
Open
S2kael
S2kael requested changes Oct 18, 2024
View reviewed changes
packages/extension-base/src/services/inapp-notification-service/index.ts

const [comparedNotifications, remindTimeConfig] = await Promise.all([
this.fetchNotificationsByParams({ notificationTab: NotificationTab.ALL, proxyId }),
await fetchLastestRemindNotificationTime()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetching everytime?

@saltict saltict temporarily deployed to pull request October 18, 2024 11:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S2kael S2kael S2kael requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@bluezdot bluezdot

Labels
None yet
Projects
None yet
Milestone
Milestone 8
Development

Successfully merging this pull request may close these issues.

Implement notification logic Extension - Support Notification UI in app Integrate Avail Bridge
4 participants
@bluezdot @saltict @S2kael @dungnguyen-art