Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web App - Update bottom padding for modals #3429

Open
dungnguyen-art opened this issue Aug 6, 2024 · 4 comments · May be fixed by #3431
Open

Web App - Update bottom padding for modals #3429

dungnguyen-art opened this issue Aug 6, 2024 · 4 comments · May be fixed by #3431
Assignees
@dungnguyen-art

Comments

@dungnguyen-art
Copy link

dungnguyen-art commented Aug 6, 2024 •
edited
Loading

Require: Update the bottom padding of modals on the web app from 16px to 32px.
Ticket: https://discord.com/channels/447263980252037141/1269978652859301911/1270252098235142146
@dungnguyen-art dungnguyen-art mentioned this issue Aug 6, 2024
Closed
10 tasks
@dungnguyen-art dungnguyen-art changed the title Update popup Web App: Update bottom padding for modals Aug 6, 2024
@dungnguyen-art dungnguyen-art self-assigned this Aug 6, 2024
@dungnguyen-art dungnguyen-art linked a pull request Aug 6, 2024 that will close this issue
[Issue-3429] Web App: Update bottom padding for modals #3431
Open
@dungnguyen-art dungnguyen-art changed the title Web App: Update bottom padding for modals Web App - Update bottom padding for modals Aug 7, 2024
@haiyenvu23
Copy link

haiyenvu23 commented Aug 9, 2024 •
edited by dungnguyen-art
Loading

Version test : https://cf0b6824.subwallet-webapp.pages.dev/

  • Re-check some screen

Image

Image

@dungnguyen-art
Copy link
Author

dungnguyen-art commented Aug 12, 2024 •
edited
Loading

  1. Image 1: It's not a modal, so it doesn't have an effect.
  2. Image 2: I see it has a bottom padding of 32px.

Image

cc @haiyenvu23

@haiyenvu23
Copy link

haiyenvu23 commented Aug 13, 2024 •
edited by dungnguyen-art
Loading

Version test : https://cf0b6824.subwallet-webapp.pages.dev/home/tokens

  • Check padding on some screens

Image

Image

Image

Image

@haiyenvu23
Copy link

  • Temporarily pending, need to consider checking again with the extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dungnguyen-art dungnguyen-art

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue-3429] Web App: Update bottom padding for modals Koniverse/SubWallet-Extension
2 participants
@dungnguyen-art @haiyenvu23