Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebApp - Bug related to Swap feature #2780

Closed
10 tasks done
Sokol142196 opened this issue Mar 20, 2024 · 3 comments · Fixed by #3427
Closed
10 tasks done

WebApp - Bug related to Swap feature #2780

Sokol142196 opened this issue Mar 20, 2024 · 3 comments · Fixed by #3427
Assignees

Comments

@Sokol142196
Copy link

Sokol142196 commented Mar 20, 2024

Describe the task

  • Not allow close popup "Still there" when out focus

    • Actual: When out focus (click on background) then popup "Still there" is closed and quote do not reset
    • Expect: Do not close popup "Still there" when out focus
  • Add validate require for Amount and validate Amount > 0

  • Handle case show history of the recipient account in case recipient account in wallet

    • Actual: Do not show history
    • Expect: Show history
  • UI bug with large number

    image

  • UI bug when Select token => Do not reproduce, temporarily skip

    image

  • Update style

    image

  • Update style token name

    image

  • Update text on Swap confirmation

    image

  • Filter out "To token" by "From token"

    • Actual: "From token" is empty but 'To token' still show all -> incorrect pair
      image

    • Expect: Filter out "To token" by "From token"


Bugs on responsive

@haiyenvu23
Copy link

haiyenvu23 commented Apr 9, 2024

Some bugs refered from issue #2758

  • Handle case Ledger account => @Sokol142196 confirmed: not handle this issue

Actual: Still show token which not supported
Expect: Filter out token not support

image

  • Update UX in case swap with XCM => @Sokol142196 confirmed: Skipped this task

  • Add message on XCM confirmation screen when swap

  • Header: Action needed

  • Message: The amount you entered is higher than your available balance on X network. You need to first transfer cross-chain from Y network to X network to continue swapping

  • Type message: info

  • UI bug
    image


  • In HydraDX, don't show tooltip when hover slippage
    Expect : Always display tooltip when hover
    Content : "Click to set your slippage tolerance"

image

@haiyenvu23
Copy link

haiyenvu23 commented Aug 9, 2024

Version test : https://49458847.subwallet-webapp.pages.dev/transaction/swap

  • Re-check UI in case show sender and recipient

Image

@haiyenvu23
Copy link

Version test: https://c25916b0.subwallet-webapp.pages.dev/transaction/swap
Validation passed in case :

  • Responsive
  • Not allow close popup "Still there" when out focus
  • Add validate require for Amount and validate Amount > 0

Image

  • Handle case show history of the recipient account in case recipient account in wallet

Image

  • UI bug with large number

Image

  • Update style

Image

Image

  • Update text on Swap confirmation

Image

  • Filter out "To token" by "From token"

Image

  • Term of service screen

Image

  • Add message on XCM confirmation screen when swap

Image

  • In HydraDX, don't show tooltip when hover slippage

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants