Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboards and charts): editable tiles | slottable menu items #1758

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

filipgutica
Copy link
Contributor

@filipgutica filipgutica commented Nov 1, 2024

Summary

  • add new edit-tile event to dashboard renderer
  • forward go-to -explore prop to analytics chart through tile definition
  • add new editable property to tile definition that will add an "edit" item to the analytics chart kebab menu. Clicking on edit, will emit an @edit-tile event with the entire GridTile object containing the tile layout, definition and index

@edit-tile event

{
    "layout": {
        "position": {
            "col": 0,
            "row": 2
        },
        "size": {
            "cols": 3,
            "rows": 2
        }
    },
    "meta": {
        "chart": {
            "type": "horizontal_bar",
            "chartTitle": "Horizontal bar chart of mock data",
            "allowCsvExport": true
        },
        "query": {
            "datasource": "basic",
            "dimensions": [
                "route"
            ]
        },
        "editable": true
    },
    "id": 3
}
image

@filipgutica filipgutica requested a review from a team as a code owner November 1, 2024 05:50
- add new edit-tile event to dashboard renderer
- forward go to explore to analytics chart through tile definition
- add new editable property to tile definition that will add an "edit" item to
the analytics chart kebab menu. Clicking on edit, will emit an @edit-tile event
with the entire GridTile<T> object containing the tile layout, definition and index
@filipgutica filipgutica force-pushed the feat/dashboard-renderer-go-to-explore branch from ee386d3 to e20f568 Compare November 1, 2024 05:54
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/analytics-chart@pr-1758
@kong-ui-public/dashboard-renderer@pr-1758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants