Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix delay clean logic when multiple healthchecker was started #147

Merged
merged 4 commits into from
Dec 22, 2023
Merged

fix: fix delay clean logic when multiple healthchecker was started #147

merged 4 commits into from
Dec 22, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Dec 14, 2023 •
edited
Loading

backport #146

FTI-5478

@oowl oowl requested a review from locao December 15, 2023 08:35
locao
locao previously approved these changes Dec 18, 2023
View reviewed changes
windmgc
windmgc approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one minor question

.github/workflows/old_os.yml Show resolved Hide resolved
@oowl oowl merged commit 4972646 into release/1.5.x Dec 22, 2023
7 checks passed
@oowl oowl mentioned this pull request Dec 22, 2023
Merged
@oowl oowl deleted the fix-active-healthcheck-clean-logic-1.5 branch December 22, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windmgc windmgc windmgc approved these changes

@ms2008 ms2008 ms2008 approved these changes

@outsinre outsinre outsinre approved these changes

@locao locao locao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oowl @windmgc @ms2008 @locao @outsinre