Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use go-database-reconciler #5156

Merged
merged 3 commits into from
Nov 21, 2023
Merged

chore: use go-database-reconciler #5156

merged 3 commits into from
Nov 21, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Nov 14, 2023

What this PR does / why we need it:

Replaces deck imports with equivalent go-database-reconciler imports.

Which issue this PR fixes:

Part of Kong/deck#1060

Special notes for your reviewer:

Draft pending an actual release of go-database-reconciler.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (657011a) 77.8% compared to head (c15b468) 77.9%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5156     +/-   ##
=======================================
+ Coverage   77.8%   77.9%   +0.1%     
=======================================
  Files        169     169             
  Lines      19007   19007             
=======================================
+ Hits       14794   14821     +27     
+ Misses      3371    3350     -21     
+ Partials     842     836      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 17, 2023
@rainest rainest marked this pull request as ready for review November 17, 2023 20:59
@rainest rainest requested a review from a team as a code owner November 17, 2023 20:59
@rainest rainest enabled auto-merge (rebase) November 17, 2023 20:59
@rainest rainest merged commit c52709b into main Nov 21, 2023
@rainest rainest deleted the chore/gdr-lib branch November 21, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants