Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kinput): add type button to mask toggle #2563

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

lukewhchen
Copy link
Contributor

@lukewhchen lukewhchen commented Jan 10, 2025

Summary

To fix the issue when clicking the mask-toggle button triggers a form submission.
slack: https://kongstrong.slack.com/archives/C05UE909XU5/p1736469294982699

After fix:

Screen.Recording.2025-01-10.at.9.46.15.AM.mov

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 7d63c91
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6781553eff9f7a0008ab8a37
😎 Deploy Preview https://deploy-preview-2563--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 7d63c91
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6781553ebf0caf00085b4cf0
😎 Deploy Preview https://deploy-preview-2563--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lukewhchen lukewhchen marked this pull request as ready for review January 10, 2025 17:50
@lukewhchen lukewhchen requested review from jillztom, Justineo and a team as code owners January 10, 2025 17:50
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukewhchen lukewhchen merged commit e83637e into main Jan 10, 2025
11 checks passed
@lukewhchen lukewhchen deleted the fix-type-button branch January 10, 2025 17:57
kongponents-bot pushed a commit that referenced this pull request Jan 10, 2025
## [9.16.1](v9.16.0...v9.16.1) (2025-01-10)

### Bug Fixes

* **kinput:** add type button to mask toggle ([#2563](#2563)) ([e83637e](e83637e))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants