Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(clustering/rpc): add required field for mocked workspace to byass validation #14213

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Jan 22, 2025

Summary

The original constructed workspace lack required fields, this commit adds them to bypass DP's delta validation.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5897

@chobits chobits requested a review from chronolaw January 22, 2025 09:47
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 22, 2025
@chobits
Copy link
Contributor Author

chobits commented Jan 22, 2025

Try to fix the test case failure in the master branch. The original validation PR was merged without a rebase, which resulted in the test case associated with the commit merged two hours ago failing

@ADD-SP ADD-SP added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jan 22, 2025
@ADD-SP ADD-SP merged commit c4093c0 into master Jan 22, 2025
38 checks passed
@ADD-SP ADD-SP deleted the fix/rpc_notify_case branch January 22, 2025 10:06
@ADD-SP ADD-SP changed the title fix(clustering/rpc): added required field for mocked workspace to byass validation tests(clustering/rpc): add required field for mocked workspace to byass validation Jan 22, 2025
@chronolaw chronolaw removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants