Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(clustering): errors spec only for sync.v1 #14179

Merged
merged 2 commits into from
Jan 17, 2025
Merged

tests(clustering): errors spec only for sync.v1 #14179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
669fb91
tests(clustering): errors spec only for sync.v1
chronolaw Jan 16, 2025
81ebc46
lint fix
chronolaw Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions spec/02-integration/09-hybrid_mode/12-errors_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,9 @@ local function get_error_report(client, msg)
end


-- XXX TODO: mock_cp does not support rpc sync rpc
for _, rpc_sync in ipairs { "off" } do
-- these tests are only for sync v1
for _, strategy in helpers.each_strategy() do
describe("CP/DP sync error-reporting with #" .. strategy .. " rpc_sync=" .. rpc_sync .. " backend", function()
describe("CP/DP sync error-reporting with #" .. strategy .. " backend", function()
local client
local cluster_port
local cluster_ssl_port
Expand Down Expand Up @@ -102,7 +101,7 @@ for _, strategy in helpers.each_strategy() do
-- use a small map size so that it's easy for us to max it out
lmdb_map_size = "1m",
plugins = "bundled,cluster-error-reporting",
cluster_rpc_sync = rpc_sync,
cluster_rpc_sync = "off",
}, nil, nil, fixtures))
end)

Expand Down Expand Up @@ -260,4 +259,3 @@ for _, strategy in helpers.each_strategy() do
end)
end)
end -- for _, strategy
end -- for rpc_sync
Loading