fix(plugins): Fixed the stale header cache that causes a break in grpc-web & grpc-gateway plugins
#14166
+146
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
cherry-pick kong-ee
liverpool8056
force-pushed
the
fix/phase_local_header_cache
branch
from
7674b20 to
4fa8cd4
Compare
(transfer-encoding) header would not be sent to the upstream gRPC servers when `grpc-web` or `grpc-gateweay` are in use The bug was caused by a regression in kong.tools.http.get_header() where the header cache was probably a stale one. FTI-6410
liverpool8056
force-pushed
the
fix/phase_local_header_cache
branch
from
4fa8cd4 to
a2720e6
Compare
gszr
approved these changes
Jan 15, 2025
locao
approved these changes
Jan 15, 2025
gszr
added
cherry-pick kong-ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A regression in kong.tools.http.get_header() where the header cache was probably a stale one was causing
grpc-weborgrpc-gateweayplugins unable to work.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-6410