Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changelog): update changelog description #13792

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

catbro666
Copy link
Contributor

@catbro666 catbro666 commented Oct 25, 2024

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix https://konghq.atlassian.net/browse/FTI-6275

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 25, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 25, 2024
Copy link
Contributor

@outsinre outsinre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that add the FTI ticket and previous PR in the discription.

@windmgc windmgc merged commit 044b4c5 into master Oct 28, 2024
19 checks passed
@windmgc windmgc deleted the update-bump-lua-kong-nginx-module-changelog branch October 28, 2024 06:48
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13792-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13792-to-master-to-upstream
git checkout -b cherry-pick-13792-to-master-to-upstream
ancref=$(git merge-base d492a12705656f666d698982e2680ec9dd8c2a87 fb865ea0d6cdd94802af710ecf7a46e824c3d7b8)
git cherry-pick -x $ancref..fb865ea0d6cdd94802af710ecf7a46e824c3d7b8

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 28, 2024
@kikito
Copy link
Member

kikito commented Oct 29, 2024

Cherrypick in https://github.com/Kong/kong-ee/pull/10531

@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants