Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump lua-resty-ljsonschema to 1.2.0 #13783

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

liverpool8056
Copy link
Contributor

@liverpool8056 liverpool8056 commented Oct 24, 2024

Summary

Changelog for ljsonschema-1.2.0:

1.2.0 (23-Oct-2024)
fix: properly calculate utf8 sequence lengths instead of byte count (Tieske/lua-resty-ljsonschema#30)
fix: support null as an option in enum types (Tieske/lua-resty-ljsonschema#26)
chore: update the test suite to a more recent version; 23.2.0 (Tieske/lua-resty-ljsonschema#27)
chore: list all disabled tests as pending (to make them visible) (Tieske/lua-resty-ljsonschema#27)
fix: fix numeric overflow (new case from updated test-suite) (Tieske/lua-resty-ljsonschema#27)
chore: restructure documentation and more repo-maintenance (Tieske/lua-resty-ljsonschema#25)

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-5870, FTI-6171

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 24, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 24, 2024
@ADD-SP ADD-SP changed the title chore(deps): Bumped lua-resty-ljsonschema to 1.2.0 chore(deps): bump lua-resty-ljsonschema to 1.2.0 Oct 24, 2024
@ADD-SP ADD-SP changed the title chore(deps): bump lua-resty-ljsonschema to 1.2.0 chore(deps): bump lua-resty-ljsonschema to 1.2.0 Oct 24, 2024
…r `null`

as a valid option in `enum` types and properly calculation of utf8 string
length instead of byte count.
@windmgc
Copy link
Member

windmgc commented Oct 24, 2024

It seems the manifest verification is failing

@liverpool8056 liverpool8056 marked this pull request as draft October 24, 2024 07:11
@@ -42,7 +42,7 @@ dependencies = {
"lua-resty-session == 4.0.5",
"lua-resty-timer-ng == 0.2.7",
"lpeg == 1.1.0",
"lua-resty-ljsonschema == 1.1.6-2",
"lua-resty-ljsonschema == 1.2.0-1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not be pinning revisions I think. Just 1.2.0 should suffice

Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liverpool8056 liverpool8056 marked this pull request as ready for review October 24, 2024 14:21
@windmgc windmgc merged commit d492a12 into master Oct 25, 2024
26 checks passed
@windmgc windmgc deleted the chore-ljsonschema-1.2.0 branch October 25, 2024 03:55
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13783-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13783-to-master-to-upstream
git checkout -b cherry-pick-13783-to-master-to-upstream
ancref=$(git merge-base 75992713bec9db211572ed8f121d1a62a753ee67 e518949d837cad96f65131dd5862f15607c4eea2)
git cherry-pick -x $ancref..e518949d837cad96f65131dd5862f15607c4eea2

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 25, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants