Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-proxy): (Bedrock)(Gemini)(AG-154) fixed tools-functions calls coming back empty #13760

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tysoekong
Copy link
Contributor

@tysoekong tysoekong commented Oct 16, 2024

Summary

  • Fixes Bedrock, Gemini function calling in AI-Proxy system (AG-154)
  • Fixes "image_url" type message not working in Bedrock (AG-155)

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

AG-154
AG-155

return new_r, "application/json", nil
end

local new_r = {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was all duplicate from some rebase... somehow.

@tysoekong tysoekong marked this pull request as ready for review October 16, 2024 15:04
@tysoekong
Copy link
Contributor Author

@fffonion @subnetmarco Let's go

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 16, 2024
@tysoekong
Copy link
Contributor Author

tysoekong commented Oct 16, 2024

spec/03-plugins/39-ai-request-transformer/02-integration_spec.lua is a genuine failure. I never get this right first-go, argh.

I'll fix it...

@@ -51,6 +57,48 @@ local function to_tool_config(request_table)
}
end

local function to_tools(in_tools)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's have a happy path test for this, to ensure the in and out format

@tysoekong tysoekong force-pushed the fix/AG-154_bedrock_gemini_function_calling branch 2 times, most recently from e66c485 to b5414c2 Compare October 25, 2024 17:16
@tysoekong tysoekong force-pushed the fix/AG-154_bedrock_gemini_function_calling branch from b5414c2 to 0124b09 Compare October 25, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants