fix(ai-proxy): (Bedrock)(Gemini)(AG-154) fixed tools-functions calls coming back empty #13760
+266
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
tysoekong
force-pushed
the
fix/AG-154_bedrock_gemini_function_calling
branch
from
18eccd6
to
7ebdfe3
Compare
tysoekong
commented
Oct 16, 2024
| return new_r, "application/json", nil | ||
| end | ||
|
|
||
| local new_r = {} |
There was a problem hiding this comment.
This was all duplicate from some rebase... somehow.
|
@fffonion @subnetmarco Let's go |
team-gateway-bot
added
the
author/community
|
I'll fix it... |
fffonion
reviewed
Oct 17, 2024
| @@ -51,6 +57,48 @@ local function to_tool_config(request_table) | |||
| } | |||
| end | |||
|
|
|||
| local function to_tools(in_tools) | |||
There was a problem hiding this comment.
let's have a happy path test for this, to ensure the in and out format
tysoekong
force-pushed
the
fix/AG-154_bedrock_gemini_function_calling
branch
2 times, most recently
from
e66c485
to
b5414c2
Compare
tysoekong
force-pushed
the
fix/AG-154_bedrock_gemini_function_calling
branch
from
b5414c2
to
0124b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
AG-154
AG-155