Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explain_manifest): fix behaviour change or API after version bump #13721

Merged
merged 1 commit into from
Sep 29, 2024
Merged

fix(explain_manifest): fix behaviour change or API after version bump #13721

merged 1 commit into from
Sep 29, 2024

Conversation

fffonion
Copy link
Contributor

Regression from #13639

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 29, 2024
@fffonion
Copy link
Contributor Author

cherrypick in #13721

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
ADD-SP
ADD-SP approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please don't forget to revert full matrix before merging.

@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@fffonion
Copy link
Contributor Author

good run https://github.com/Kong/kong/actions/runs/11091278995/job/30814898290?pr=13721

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@ADD-SP ADD-SP merged commit 778fe08 into master Sep 29, 2024
37 checks passed
@ADD-SP ADD-SP deleted the fix-manifest-runpath branch September 29, 2024 09:58
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13721-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13721-to-master-to-upstream
git checkout -b cherry-pick-13721-to-master-to-upstream
ancref=$(git merge-base 695e8ec84669892b2efdee754e4f772bcd47ab1f c77f917e6865125d929f244b715b96eb6d42f7e2)
git cherry-pick -x $ancref..c77f917e6865125d929f244b715b96eb6d42f7e2

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 29, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyZhang0707 AndyZhang0707 AndyZhang0707 approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@fffonion fffonion

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fffonion @team-gateway-bot @AndyZhang0707 @ADD-SP @kikito