Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): use ubi8 -> ubi9 #13574

Merged
merged 2 commits into from
Sep 18, 2024
Merged

chore(docker): use ubi8 -> ubi9 #13574

merged 2 commits into from
Sep 18, 2024

Conversation

curiositycasualty
Copy link
Contributor

Summary

This PR updates the Dockerfile used when building RHEL-family docker images so that it uses redhat/ubi9 as its base.

Checklist

  • [na] The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@github-actions github-actions bot added build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Aug 26, 2024
@@ -0,0 +1,2 @@
message: "Bumped rpm dockerfile to UBI 9"
Copy link
Contributor

@fffonion fffonion Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually suggest to drop this this changelog as we just changed the placeholder value, but user won't expect changes so having this could lead to confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me update the changelog entry to reflect the fact that I'm changing the default value of the argument. I can practically agurentee that we have folks building using this dockerfile that don't supply any build-args.

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 16, 2024
@curiositycasualty curiositycasualty merged commit bbc7360 into master Sep 18, 2024
26 checks passed
@curiositycasualty curiositycasualty deleted the chore/ubi9 branch September 18, 2024 17:46
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13574-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13574-to-master-to-upstream
git checkout -b cherry-pick-13574-to-master-to-upstream
ancref=$(git merge-base 1c4b859be73f716b8e6796868cc35a9eee7413ca 02094d0f6426ace66166f0ec8ea8da42196084e0)
git cherry-pick -x $ancref..02094d0f6426ace66166f0ec8ea8da42196084e0

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 18, 2024
@kikito
Copy link
Member

kikito commented Sep 24, 2024

Added internal code to track the EE cherrypick: KAG-5466

curiositycasualty added a commit that referenced this pull request Oct 15, 2024
* chore(docker): use ubi8 -> ubi9

* chore(changelog): update text

(cherry picked from commit bbc7360)
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants