-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): use ubi8 -> ubi9 #13574
Conversation
@@ -0,0 +1,2 @@ | |||
message: "Bumped rpm dockerfile to UBI 9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually suggest to drop this this changelog as we just changed the placeholder value, but user won't expect changes so having this could lead to confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me update the changelog entry to reflect the fact that I'm changing the default value of the argument. I can practically agurentee that we have folks building using this dockerfile that don't supply any build-args.
1928654
to
02094d0
Compare
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13574-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13574-to-master-to-upstream
git checkout -b cherry-pick-13574-to-master-to-upstream
ancref=$(git merge-base 1c4b859be73f716b8e6796868cc35a9eee7413ca 02094d0f6426ace66166f0ec8ea8da42196084e0)
git cherry-pick -x $ancref..02094d0f6426ace66166f0ec8ea8da42196084e0 |
Added internal code to track the EE cherrypick: KAG-5466 |
* chore(docker): use ubi8 -> ubi9 * chore(changelog): update text (cherry picked from commit bbc7360)
Summary
This PR updates the Dockerfile used when building RHEL-family docker images so that it uses redhat/ubi9 as its base.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.md