-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clustering): introduce incremental sync for clustering #13157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
core/db/migrations
core/clustering
core/templates
core/db
core/configuration
schema-change-noteworthy
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Jun 4, 2024
dndx
force-pushed
the
feat/incremental
branch
3 times, most recently
from
June 4, 2024 17:13
88e177a
to
e64c085
Compare
chronolaw
force-pushed
the
feat/incremental
branch
from
July 4, 2024 01:33
e64c085
to
2692ea9
Compare
dndx
force-pushed
the
feat/incremental
branch
2 times, most recently
from
August 7, 2024 03:27
856ca04
to
50528fd
Compare
3 tasks
dndx
force-pushed
the
feat/incremental
branch
from
September 9, 2024 09:05
dbe6259
to
573852d
Compare
chronolaw
force-pushed
the
feat/incremental
branch
2 times, most recently
from
September 24, 2024 08:44
a558f38
to
b11e659
Compare
dndx
commented
Sep 26, 2024
chronolaw
changed the title
Incremental sync PoC
feat(clustring): introduce incremental sync for clustering
Sep 26, 2024
chronolaw
changed the title
feat(clustring): introduce incremental sync for clustering
feat(clusteriing): introduce incremental sync for clustering
Sep 26, 2024
dndx
commented
Sep 27, 2024
chronolaw
force-pushed
the
feat/incremental
branch
from
September 30, 2024 07:06
bebd9ed
to
68849c4
Compare
This reverts commit 95f5cc6.
* fix(tests): enable inc sync for 01-sync_spec.lua * fix(incremental): dont delete old entity from LMDB if we clear it already * dont modify crud type even though we dont delete old entity from lmdb * localize ns_delta.wipe * localize ns_delta.wipe - part 2 * fix that cp will not init clustering * refactor old_entity logic * cp should always support full sync protocol * Revert "cp should always support full sync protocol" This reverts commit 6803958. * Revert "fix that cp will not init clustering" This reverts commit b84f261. * Revert "fix(tests): enable inc sync for 01-sync_spec.lua" This reverts commit 54d0f54. --------- Co-authored-by: chronolaw <[email protected]>
This reverts commit adcbbf0.
dndx
force-pushed
the
feat/incremental
branch
from
October 16, 2024 13:29
0df05a4
to
7c02759
Compare
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13157-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13157-to-master-to-upstream
git checkout -b cherry-pick-13157-to-master-to-upstream
ancref=$(git merge-base 9ae36382db4b9485f8889b8cd80d66a0885c86e7 7c027596914938766d7c93d74406f894dc19aa96)
git cherry-pick -x $ancref..7c027596914938766d7c93d74406f894dc19aa96 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Oct 16, 2024
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/clustering
core/configuration
core/db/migrations
core/db
core/pdk
core/proxy
core/templates
schema-change-noteworthy
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAG-4865
KAG-2986
KAG-2987
KAG-3502
KAG-3258
KAG-5283
NOTE:
cluster_rpc
now ison
by defaultcluster_incremental_sync
now isoff
by default, we will continue to fix tests after this PR then turn it on.Flaky (perhaps need rerun):