fix(certificate): properly throw errors when parsing certificate from…

… the vault (#14212) get_certificate was not handling certificate parsing errors after a vault update. This fixes it. FTI-6392
Kong · Feb 5, 2025 · cb90115 · cb90115 · github-actions · Feb 5, 2025
1 parent 6617d58
commit cb90115
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog/unreleased/kong/fix-error-handle-certificate.yml b/changelog/unreleased/kong/fix-error-handle-certificate.yml
@@ -0,0 +1,3 @@
+message: "Fixed an issue where the error was not thrown when parsing the certificate from vault."
+type: bugfix
+scope: Core
diff --git a/kong/runloop/certificate.lua b/kong/runloop/certificate.lua
@@ -261,7 +261,7 @@ local function get_certificate(pk, sni_name, ws_id)
                                                           pk, sni_name, ws_id)
 
   if certificate and hit_level ~= 3 and certificate["$refs"] then
-    certificate = parse_key_and_cert(kong.vault.update(certificate))
+    certificate, err = parse_key_and_cert(kong.vault.update(certificate))
   end
 
   return certificate, err