Skip to content

Commit

Permalink
tests(clustering): errors spec only for sync.v1 (#14179)
Browse files Browse the repository at this point in the history
  • Loading branch information
chronolaw authored Jan 17, 2025
1 parent e5f959d commit 6a81453
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions spec/02-integration/09-hybrid_mode/12-errors_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,9 @@ local function get_error_report(client, msg)
end


-- XXX TODO: mock_cp does not support rpc sync rpc
for _, rpc_sync in ipairs { "off" } do
-- these tests are only for sync v1
for _, strategy in helpers.each_strategy() do
describe("CP/DP sync error-reporting with #" .. strategy .. " rpc_sync=" .. rpc_sync .. " backend", function()
describe("CP/DP sync error-reporting with #" .. strategy .. " backend", function()
local client
local cluster_port
local cluster_ssl_port
Expand Down Expand Up @@ -102,7 +101,7 @@ for _, strategy in helpers.each_strategy() do
-- use a small map size so that it's easy for us to max it out
lmdb_map_size = "1m",
plugins = "bundled,cluster-error-reporting",
cluster_rpc_sync = rpc_sync,
cluster_rpc_sync = "off",
}, nil, nil, fixtures))
end)

Expand Down Expand Up @@ -260,4 +259,3 @@ for _, strategy in helpers.each_strategy() do
end)
end)
end -- for _, strategy
end -- for rpc_sync

1 comment on commit 6a81453

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel Build

Docker image available kong/kong-dev:6a81453ac7c2ab75c2a4f7e5893162a5cf90f92c
Artifacts available https://github.com/Kong/kong/actions/runs/12824473972

Please sign in to comment.