fix: returning a validation error in case of wrong configuration. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 28.72% 28.67% -0.05%
==========================================
Files 106 106
Lines 15888 15915 +27
==========================================
Hits 4564 4564
- Misses 10842 10869 +27
Partials 482 482 ☔ View full report in Codecov by Sentry. |
pmalek
reviewed
Jan 8, 2025
As of now, while using deck to create a route-scoped plugin with a `service` field defined, the sync goes through the first time but errors out subsequently. Under a route, we do not want the user to add the `service` field for a plugin. Thus, we are checking for this specific scenario and erroring out, instead of letting the sync action go through. For: Kong/deck#1353
A foreign key nested under a plugin of a different scope would error out. This would make sure that a sync does not go through when wrong configurations are passed via deck. An example would be adding a `service` field in a plugin, nested under a route. This change ensures more such issues do not come up.
Prashansa-K
force-pushed
the
fix/nested-service-route-plugin
branch
from
42059b2 to
c2be37c
Compare
Thank you! |
pmalek
approved these changes
Jan 10, 2025
Sorry. I get these mixed up as those repos have different approaches to handling changelog. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, while using deck to create a
route-scoped plugin with a
servicefielddefined, the sync goes through the first
time but errors out subsequently. Under a
route, we do not want the user to add the
servicefield for a plugin. Thus, we arechecking for this specific scenario and
erroring out, instead of letting the sync
action go through.
For: Kong/deck#1353
Documentation
Testing