Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a NoDeletes function to the Syncer #143

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Adds a NoDeletes function to the Syncer #143

wants to merge 2 commits into from

Conversation

rspurgeon
Copy link
Collaborator

Summary

If the Syncer is configured with noDeletes true, deleteDuplicates and delete operations are skipped entirely in the diff() function.

Testing WIP

Full changelog

  • Adds NoDeletes function to Syncer. Usage of this feature in decK will come in a subsequent change.

Testing

Testing WIP, Draft PR for now.

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.81%. Comparing base (01fa2d0) to head (3f8581f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/diff/diff.go 0.00% 8 Missing ⚠️
pkg/file/writer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   29.88%   29.81%   -0.07%     
==========================================
  Files         106      106              
  Lines       12631    12596      -35     
==========================================
- Hits         3775     3756      -19     
+ Misses       8393     8377      -16     
  Partials      463      463              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

If the Syncer is configured with noDeletes true, deleteDuplicates and delete operations
are skipped entirely in the diff() function.

Testing WIP
Fixes up unnecessary loop var copies across multiple files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants