Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom-dns.md #8399

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Update custom-dns.md #8399

merged 2 commits into from
Jan 31, 2025
+13 −0

Conversation

josh-konghq
Copy link
Contributor

@josh-konghq josh-konghq commented Jan 31, 2025 •
edited
Loading

Updated to include instructions for CAA Records

Description

Testing instructions

Preview link:

Checklist

@josh-konghq
Update custom-dns.md
626edec 
Updated to include instructions for CAA Records
@josh-konghq josh-konghq requested a review from a team as a code owner January 31, 2025 17:45
@netlify Netlify
Copy link

netlify bot commented Jan 31, 2025 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 5b88cf0
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/679d35cbc2692f0008047978
😎 Deploy Preview https://deploy-preview-8399--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 92 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Guaris Guaris self-assigned this Jan 31, 2025
@josh-konghq josh-konghq added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Jan 31, 2025
cloudjumpercat
cloudjumpercat approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making these updates!

@cloudjumpercat cloudjumpercat merged commit 9b2543a into main Jan 31, 2025
16 checks passed
@cloudjumpercat cloudjumpercat deleted the josh-konghq-patch-1 branch January 31, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudjumpercat cloudjumpercat cloudjumpercat approved these changes

Assignees

@Guaris Guaris

Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh-konghq @cloudjumpercat @Guaris