Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(workspace): Add warnings to kong migrations #8092

Merged
merged 3 commits into from
Oct 29, 2024
Merged

docs(workspace): Add warnings to kong migrations #8092

merged 3 commits into from
Oct 29, 2024

Conversation

Oyami-Srk
Copy link
Member

@Oyami-Srk Oyami-Srk commented Oct 28, 2024 •
edited by lena-larionova
Loading

Description

We currently need force upgrading to make sure the schema is correct and up-to-date.
This PR adds warnings to the upgrading guide, API doc, and CLI doc.

KAG-5040

Testing instructions

Preview link:

Checklist

@Oyami-Srk
docs(workspace): add various warning to kong migrations finish.
87352d4 
We currently need force upgrading to make sure the schema is correct and up-to-date.
@Oyami-Srk Oyami-Srk added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Oct 28, 2024
@Oyami-Srk Oyami-Srk requested a review from a team as a code owner October 28, 2024 04:58
@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 6047c64
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/672038ba98d23d000803492f
😎 Deploy Preview https://deploy-preview-8092--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 93 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ This PR edits generated files. Please make sure that the source file is updated.

https://github.com/Kong/kong/tree/master/kong/cmd:

  • app/_src/gateway/reference/cli.md

@Oyami-Srk Oyami-Srk changed the title docs(workspace): add various warning to kong migrations finish. docs(workspace): Add warnings to kong migrations Oct 28, 2024
lena-larionova
lena-larionova requested changes Oct 29, 2024
View reviewed changes
app/_includes/md/enterprise/migration-finish-warning.md Outdated Show resolved Hide resolved
app/_src/gateway/admin-api/workspaces/reference.md Outdated Show resolved Hide resolved
app/_src/gateway/breaking-changes/34x.md Outdated Show resolved Hide resolved
app/_src/gateway/migrate-ce-to-ke.md Outdated Show resolved Hide resolved
app/_src/gateway/reference/cli.md Outdated Show resolved Hide resolved
app/_src/gateway/upgrade/blue-green.md Outdated Show resolved Hide resolved
app/_src/gateway/upgrade/in-place.md Outdated Show resolved Hide resolved
app/gateway/changelog.md Outdated Show resolved Hide resolved
@Oyami-Srk @lena-larionova
Apply suggestions
6047c64 
Co-authored-by: lena-larionova <[email protected]>
lena-larionova
lena-larionova approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Link checker flagged no 404s, only 429s on github links.

@lena-larionova lena-larionova merged commit e92ccb3 into main Oct 29, 2024
30 of 33 checks passed
@lena-larionova lena-larionova deleted the workspace-delete-migration-warning branch October 29, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lena-larionova lena-larionova lena-larionova approved these changes

Assignees
No one assigned
Labels
ci:manual-approve:generated-files ci:manual-approve:link-validation review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oyami-Srk @lena-larionova